lkml.org 
[lkml]   [2007]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + clocksource-driver-initialize-list-value.patch added to -mm tree
On Wed, 4 Apr 2007 22:36:47 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > The struct clocksource .list field is now required to be initialized
> > before calling clocksource_register().
> >
> > This is a prerequisite for simplifying the clocksource registration
> > process.
>
> why?

It's all enablement for
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.21-rc5/2.6.21-rc5-mm4/broken-out/clocksource-refactor-duplicate-registration-checking.patch,
on which I have no opinion.


> This patch only pushes some unnecessary code into the clocksource
> drivers:
>
> + .list = LIST_HEAD_INIT(clocksource_avr32.list),
>
> NACK unless you can give an explanation of why this is unavoidable. A
> NULL initializer is just as good as an initialized list entry. (in fact
> it's slightly better because it's in the kernel's BSS)
>

No, these structures are already in .data.

.mask = CLOCKSOURCE_MASK(32),
.mult = 0,
.shift = 20,
+ .list = LIST_HEAD_INIT(clocksource_pit.list),
};
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-04-04 22:53    [W:0.081 / U:3.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site