lkml.org 
[lkml]   [2007]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    Subjectdd
    From
    Hallo.

    search-a-little-harder-for-mkimage.patch

    ------------------------------------------------------
    Subject: search a little harder for mkimage
    From: "Mike Frysinger" <vapier.adi@gmail.com>

    > Check to see if `${CROSS_COMPILE}mkimage` exists and if not, fall back to
    > the standard `mkimage`

    Why this can't be done by

    PATH=$CROSS_COMPILE:$PATH

    in your environment?

    > The Blackfin toolchain includes mkimage, but we dont want to namespace
    > collide with any of the user's system setup, so we prefix it with our
    > toolchain name.

    If that matter, `type -path' is bashizm (BloAted SHell), and "blackbox"
    with "dash" (very good `sh' equivalents) will fail. I would recomend to
    use "which" command (btw, Debian has `sh' version of it), if you
    concerned about size and performance.

    Nack + proposition to move from `bash' to `sh'.

    -MKIMAGE=$(type -path mkimage)
    +MKIMAGE=$(type -path ${CROSS_COMPILE}mkimage)

    if [ -z "${MKIMAGE}" ]; then
    - # Doesn't exist
    - echo '"mkimage" command not found - U-Boot images will not be built' >&2
    - exit 0;
    + MKIMAGE=$(type -path mkimage)
    + if [ -z "${MKIMAGE}" ]; then
    + # Doesn't exist
    + echo '"mkimage" command not found - U-Boot images will not be built' >&2
    + exit 0;
    + fi
    fi

    ____
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-02-08 06:19    [W:0.044 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site