Messages in this thread Patch in this message | | | Date | Fri, 21 Dec 2007 12:12:07 +0100 | From | Ingo Molnar <> | Subject | Re: Linux 2.6.24-rc5 x86 architecture no longer Oopses... |
| |
* Andrew Morton <akpm@linux-foundation.org> wrote:
> I'd suggest that we add a local_read_flags() along with > local_save_flags(). Then I can merge the parts of the patch which > don't get destroyed by ongoing churn and then we can come in and clean > up the stragglers later.
ah, indeed.
like the patch below? (Only local_save_flags() should be used by drivers - but i stuck in the other variants as well for completeness.)
Ingo
--------------------> Subject: migration helpers for local_save_flags => local_read_flags rename From: Ingo Molnar <mingo@elte.hu>
prepare for renaming of all local_save_flags variants to local_read_flags, via migration helpers, as suggested by Andrew Morton.
Signed-off-by: Ingo Molnar <mingo@elte.hu> --- include/linux/irqflags.h | 9 +++++++++ 1 file changed, 9 insertions(+)
Index: linux-x86.q/include/linux/irqflags.h =================================================================== --- linux-x86.q.orig/include/linux/irqflags.h +++ linux-x86.q/include/linux/irqflags.h @@ -93,4 +93,13 @@ #define irqs_disabled_flags(flags) raw_irqs_disabled_flags(flags) #endif /* CONFIG_X86 */ +/* + * Migration helpers - the proper API is the local_read_flags API. + * Will go away in v2.6.26. + */ +#define local_save_flags local_read_flags +#define __local_save_flags __local_read_flags +#define raw_local_save_flags raw_local_read_flags +#define __raw_local_save_flags __raw_local_read_flags + #endif
| |