Messages in this thread | | | Date | Thu, 20 Dec 2007 09:12:15 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page |
| |
On Thu, 20 Dec 2007 21:54:15 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> >> struct page_cgroup *page_get_page_cgroup(struct page *page) > >> { > >> return (struct page_cgroup *) > >> (page->page_cgroup & ~PAGE_CGROUP_LOCK); > >> } > >> > >> I guess the issue is that often a "get" function has a complementary > >> "put" function, but this isn't one of them. Would page_page_cgroup > >> be a better name, perhaps? I don't know. > > > > Ah, yes, I mistakenly assumed it was a reference get. In that case I > > stand corrected and do not have any objections. > > > > I was going to say the same thing, page_get_page_cgroup() does not hold > any references. May be _get_ in the name is confusing.
It is a bit unconventional. page_cgroup()?
| |