lkml.org 
[lkml]   [2007]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page
    Hugh Dickins wrote:
    > On Thu, 20 Dec 2007, Andrew Morton wrote:
    >> On Thu, 20 Dec 2007 21:54:15 +0530 Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
    >>> I was going to say the same thing, page_get_page_cgroup() does not hold
    >>> any references. May be _get_ in the name is confusing.
    >> It is a bit unconventional. page_cgroup()?
    >
    > Seems ideal to me
    > (though there is some argument for page_page_cgroup(), weird as it is).
    >
    > Hugh

    Sounds good to me as well, except that it sounds like a constructor :-)
    I'll try and make the changes and submit a patch. I am in the middle of
    losing control_type now (based on Hugh's comments)

    --
    Warm Regards,
    Balbir Singh
    Linux Technology Center
    IBM, ISTL


    \
     
     \ /
      Last update: 2007-12-20 18:43    [W:0.023 / U:239.960 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site