lkml.org 
[lkml]   [2007]   [Dec]   [19]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
FromBalbir Singh <>
DateWed, 19 Dec 2007 11:48:34 +0530
Subject[PATCH] Move page_assign_page_cgroup to VM_BUG_ON in free_hot_cold_page

Based on the recommendation and observations of Hugh Dickins,
page_cgroup_assign_cgroup() is not required. This patch replaces it with
a VM_BUG_ON, so that we can catch them in free_hot_cold_page()

Signed-off-by: Balbir Singh <balbir@linux.vnet.ibm.com>
---
 mm/page_alloc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN mm/page_alloc.c~memory-controller-move-to-bug-on-in-free_hot_cold_page mm/page_alloc.c
--- linux-2.6.24-rc5/mm/page_alloc.c~memory-controller-move-to-bug-on-in-free_hot_cold_page	2007-12-19 11:31:46.000000000 +0530
+++ linux-2.6.24-rc5-balbir/mm/page_alloc.c	2007-12-19 11:33:45.000000000 +0530
@@ -995,7 +995,7 @@ static void fastcall free_hot_cold_page(
 
 	if (!PageHighMem(page))
 		debug_check_no_locks_freed(page_address(page), PAGE_SIZE);
-	page_assign_page_cgroup(page, NULL);
+	VM_BUG_ON(page_get_page_cgroup(page));
 	arch_free_page(page, 0);
 	kernel_map_pages(page, 1, 0);
 
_
-- 
	Warm Regards,
	Balbir Singh
	Linux Technology Center
	IBM, ISTL


\
 
 \ /
  Last update: 2007-12-19 07:21    [from the cache]
©2003-2008