Messages in this thread | | | Date | Tue, 16 Oct 2007 21:31:22 -0600 | From | Matthew Wilcox <> | Subject | Re: [Pcihpd-discuss] [PATCH 2/4] Fix PCIe hotplug for non-ACPI ExpressCard slots (version 2) |
| |
On Tue, Oct 16, 2007 at 09:54:42PM -0400, Mark Lord wrote: > if (rc) > goto err_out_free_ctrl_slot; > - } > + } else if (pciehp_force) > + pciehp_enable_slot(t_slot); >
I find the construct if () { ... } else ...; to be a bit jarring. How about adding the extra braces?
-- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |