Messages in this thread | | | Date | Thu, 18 May 2006 16:07:58 -0700 | From | Andrew Morton <> | Subject | Re: [RFT] major libata update |
| |
Tejun Heo <htejun@gmail.com> wrote: > > Tejun Heo wrote: > > Andrew Morton wrote: > >> No. In fact, it doesn't even work with the 2.6.17-rc4-mm1 lineup plus > >> the > >> latest git-libata-all. It needs this tweak: > >> > >> --- devel/drivers/scsi/ata_piix.c~2.6.17-rc4-mm1-ich8-fix > >> 2006-05-16 18:36:12.000000000 -0700 > >> +++ devel-akpm/drivers/scsi/ata_piix.c 2006-05-16 > >> 18:36:12.000000000 -0700 > >> @@ -542,6 +542,14 @@ static unsigned int piix_sata_probe (str > >> port = map[base + i]; > >> if (port < 0) > >> continue; > >> + if (ap->flags & PIIX_FLAG_AHCI) { > >> + /* FIXME: Port status of AHCI controllers > >> + * should be accessed in AHCI memory space. */ > >> + if (pcs & 1 << port) > >> + present_mask |= 1 << i; > >> + else > >> + pcs &= ~(1 << port); > >> + } > >> if (ap->flags & PIIX_FLAG_IGNORE_PCS || pcs & 1 << (4 + port)) > >> present_mask |= 1 << i; > >> else > > The above patch doesn't do anything.
Yes it does. I dropped it and got
SCSI subsystem initialized ata_piix 0000:00:1f.2: MAP [ P0 P2 P1 P3 ] ACPI (acpi_bus-0191): Device is not power manageable [20060310] ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 19 (level, low) -> IRQ 19 ata1: SATA max UDMA/133 cmd 0x2148 ctl 0x217E bmdma 0x2110 irq 19 ata2: SATA max UDMA/133 cmd 0x2140 ctl 0x217A bmdma 0x2118 irq 19 ata1: SATA port has no device.
Then I undropped it and got
SCSI subsystem initialized ata_piix 0000:00:1f.2: MAP [ P0 P2 P1 P3 ] ACPI (acpi_bus-0191): Device is not power manageable [20060310] ACPI: PCI Interrupt 0000:00:1f.2[A] -> GSI 19 (level, low) -> IRQ 19 ata1: SATA max UDMA/133 cmd 0x2148 ctl 0x217E bmdma 0x2110 irq 19 ata2: SATA max UDMA/133 cmd 0x2140 ctl 0x217A bmdma 0x2118 irq 19 ata1.00: ATA-7, max UDMA/133, 321672960 sectors: LBA48 NCQ (depth 0/32) ata1.00: configured for UDMA/133 scsi0 : ata_piix
and a computer which boots.
Look closer, please ;) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |