lkml.org 
[lkml]   [2005]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: avoiding pci_disable_device()...
On Mon, Feb 14, 2005 at 08:24:29PM +0100, Takashi Iwai wrote:
> At Mon, 14 Feb 2005 11:06:19 -0800,
> Greg KH wrote:
> >
> > > As a result, I have committed the attached patch to libata-2.6. In many
> > > cases, it is a "semantic fix", addressing the case
> > >
> > > * pci_request_regions() indicates hardware is in use
> > > * we rudely disable the in-use hardware
> > >
> > > that would not occur in practice.
> > >
> > > But better safe than sorry. Code cuts cut-n-pasted all over the place.
> > >
> > > I'm hoping one or two things will happen now:
> > > * janitors fix up the other PCI drivers along these lines
> > > * improve the PCI API so that pci_request_regions() is axiomatic
> >
> > Do you have any suggestions for how to do this?
>
> How about to add an exclusiveness check in pci_enable_device()?
> Most drivers suppose that the given pci resources are exclusively
> available.

You mean only allow pci_enable_device() to work for the first caller of
it? I don't see how that would help this issue out.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.138 / U:0.092 seconds]
©2003-2011 Jasper Spaans. Advertise on this site