Messages in this thread | | | Date | Mon, 14 Feb 2005 21:05:58 -0500 | From | Jeff Garzik <> | Subject | Re: avoiding pci_disable_device()... |
| |
Arjan van de Ven wrote: >>No. You also need to consider situations such as out-of-tree drivers >>for the same hardware (might not use PCI API), and situations where you >>have peer devices discovered and used (PCI API doesn't have "hey, <this> >>device is associated with <current driver>, too" capability) > > > > there's not a lot you or anyone else can do about such broken (and often > proprietary) drivers.... if a device doesn't use the kernel API's its > end of game basically. Adding more new API's isn't going to help you ...
This specific instance isn't about adding a new API, but using an existing one correctly.
If pci_request_regions() fails, that implies another driver is using the kernel API to let you know the region is unavailable. You should honor that, by not disabling the hardware in that case.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |