Messages in this thread | | | Date | Wed, 21 Dec 2005 10:32:41 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [Alsa-devel] 2.6.15-rc6: boot failure in saa7134-alsa.c |
| |
On Wed, 21 Dec 2005, Takashi Iwai wrote: > > (And, interestingly, fs_initcall() is rarely used in the whole fs/ > codes! "grep -r fs_initcall linux/fs" hits only one file.)
Yes. That thing was probably mis-named. It's much more commonly used for a "helper subsystem", ie things like pcmcia (that want PCI to be fully initialized and probed, but want to run before the actual device drivers start probing).
> So, a "safe" solution for the time being appears to be either > - to look through the whole codes and adjust *_initcall() levels, > - to force to build saa7134-alsa as a module, or > - to move saa7134-alsa.c to sound/ directory.
Well, you dropped the easiest: make saa7134 just use "late_initcall()".
It's not "correct", but it's certainly no less correct than just forcing a driver to be moved for link order reasons.
Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |