lkml.org 
[lkml]   [2005]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/8] Cleanup kmem_cache_create()
On Mon, 7 Nov 2005, Roland Dreier wrote:

> > * Replace a constant (4096) with what it represents (PAGE_SIZE)
>
> This seems dangerous. I don't pretend to understand the slab code,
> but the current code works on architectures with PAGE_SIZE != 4096.
> Are you sure this change is correct?

Leave the constant. The 4096 is only used for debugging and is a boundary
at which redzoning and last user accounting is given up.

A large object in terms of this patch is a object greater than 4096 bytes
not an object greater than PAGE_SIZE. I think the absolute size is
desired.

Would you CC manfred on all your patches?



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-11-08 19:55    [W:0.118 / U:0.348 seconds]
©2003-2011 Jasper Spaans. Advertise on this site