![]() | |||||||||||||
Messages in this thread |
Christoph Lameter wrote: > On Mon, 7 Nov 2005, Roland Dreier wrote: > > >> > * Replace a constant (4096) with what it represents (PAGE_SIZE) >> >>This seems dangerous. I don't pretend to understand the slab code, >>but the current code works on architectures with PAGE_SIZE != 4096. >>Are you sure this change is correct? > > > Leave the constant. The 4096 is only used for debugging and is a boundary > at which redzoning and last user accounting is given up. > > A large object in terms of this patch is a object greater than 4096 bytes > not an object greater than PAGE_SIZE. I think the absolute size is > desired. Would you be OK with at least NAMING the constant? I won't name it PAGE_SIZE (of course), but LARGE_OBJECT_SIZE or something? > Would you CC manfred on all your patches? Yes. I will repost my patches later today and I will be sure to CC Manfred on all of them. Thanks for the review, -Matt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-11-08 20:07 [W:0.570 / U:0.160 seconds] ©2003-2008 Jasper Spaans | |||||||||||||