Messages in this thread |  | | | Date | Tue, 8 Nov 2005 09:34:48 +0200 (EET) | | From | Pekka J Enberg <> | | Subject | Re: [PATCH 4/8] Cleanup kmem_cache_create() |
| |
On Mon, 7 Nov 2005, Roland Dreier wrote:
> > * Replace a constant (4096) with what it represents (PAGE_SIZE) > > This seems dangerous. I don't pretend to understand the slab code, > but the current code works on architectures with PAGE_SIZE != 4096. > Are you sure this change is correct?
Looks ok to me except that it should be a separate patch (it is not a trivial cleanup because it changes how the code works).
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |