lkml.org 
[lkml]   [2005]   [Oct]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 20/22] PCI Error Recovery: e100 network device driver
    linas writes:
    > On Mon, Oct 10, 2005 at 05:10:56PM -0700, Greg KH was heard to remark:
    > > On Thu, Oct 06, 2005 at 06:57:29PM -0500, linas wrote:
    > > > +config E100_EEH_RECOVERY
    > > > + bool "Enable PCI bus error recovery"
    > > > + depends on E100 && PPC_PSERIES
    > > > + help
    > > > + If you say Y here, the driver will be able to recover from
    > > > + PCI bus errors on many PowerPC platforms. IBM pSeries users
    > > > + should answer Y.
    > >
    > > Why make a config option for this at all? Who would turn it off?
    >
    > I wanted to have this turned off for anyone who didn't have
    > hardware capable of supporting this, and didn't really think
    > about how to hide this from the menu. I guess its best to
    > just plain hide this, keep the menus from getting cluttered.

    I would think we could have one config option to enable PCI bus error
    recovery generally, and have the code in the drivers enabled by that.
    I don't think we need an individual config option for each driver to
    enable PCI error recovery.

    Regards,
    Paul.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-10-12 08:00    [W:0.021 / U:61.332 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site