lkml.org 
[lkml]   [2005]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 20/22] PCI Error Recovery: e100 network device driver
On Thu, Oct 06, 2005 at 06:57:29PM -0500, linas wrote:
> +config E100_EEH_RECOVERY
> + bool "Enable PCI bus error recovery"
> + depends on E100 && PPC_PSERIES
> + help
> + If you say Y here, the driver will be able to recover from
> + PCI bus errors on many PowerPC platforms. IBM pSeries users
> + should answer Y.

Why make a config option for this at all? Who would turn it off?

> @@ -2661,6 +2731,9 @@
> .resume = e100_resume,
> #endif
> .shutdown = e100_shutdown,
> +#ifdef CONFIG_E100_EEH_RECOVERY
> + .err_handler = &e100_err_handler,
> +#endif /* CONFIG_E100_EEH_RECOVERY */

No, don't put #ifdefs in the middle of a structure, remember we made
err_handler always present in the .h file for a reason...

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-10-11 02:14    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site