lkml.org 
[lkml]   [2004]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [announce] HVCS for inclusion in 2.6 tree
From
Date
On Sat, 2004-07-17 at 21:00, Paul Mackerras wrote:
> The arch/ppc64 stuff mostly looks OK - however I would prefer that you
> created a new arch/ppc64/kernel/hvcs.c (and include/asm-ppc64/hvcs.h)
> rather than tripling the size of the existing hvconsole.c. There are
> a couple of whitespace nits (missing space after "if" in a couple of
> places), and this:

Paul, Thanks for the comments. Maybe it would be better to avoid
repetition of file names and create include/asm-ppc64/hvcserver.h and
arch/ppc64/kernel/hvcserver.c?

> > +#define HVCS_LONG_INVALID 0xFFFFFFFFFFFFFFFF
>
> would look better as either ~0UL or -1L (and I don't see why it really
> needs a #define).

Well, since the assigned variables are "unsigned long" I suppose ~OUL
would be more appropriate.

Ryan S. Arnold
IBM Corporation, Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.075 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site