lkml.org 
[lkml]   [2004]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [announce] HVCS for inclusion in 2.6 tree
Ryan Arnold <rsa@us.ibm.com> wrote:
>
>
> +/* This function is executed by the driver "rescan" sysfs entry */
> +static int hvcs_rescan_devices_list(void)
> +{
> + struct hvcs_struct *hvcsd = NULL;
> + unsigned long flags;
> +
> + /* Locking issues? */
> + list_for_each_entry(hvcsd, &hvcs_structs, next) {
>

Well yes. hvcs_structs definitely needs locking. If it's easy to do then
slapping a semaphore around it should be a five-minute job. If it's hard
to do then now is the best time to do it, while the code is fresh in one's
mind, no?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [from the cache]
©2003-2011 Jasper Spaans