Messages in this thread | | | Subject | Re: [announce] HVCS for inclusion in 2.6 tree | From | Ryan Arnold <> | Date | Mon, 26 Jul 2004 07:57:13 -0500 |
| |
On Thu, 2004-07-22 at 21:21, Andrew Morton wrote: > > + retval = hvcs_get_partner_info(unit_address, &head, hvcs_pi_buff); > > + if (retval) { > > + printk(KERN_ERR "HVCS: Failed to fetch partner" > > + " info for vty-server@%x.\n",unit_address); > > + spin_lock_irqsave(&hvcs_pi_lock, flags); > > ^^ spin_unlock > > > + return retval; > > + } > > + spin_unlock_irqrestore(&hvcs_pi_lock, flags); > > > > (Just move the spin_unlock() to be prior to the test of retval). > > Suggest you review all similar code in the patch for the same copy-n-paste > bug.
Whoops! Thanks for catching that. I'll make sure it doesn't show up elsewhere.
Ryan S. Arnold IBM Linux Technology Center
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |