lkml.org 
[lkml]   [2004]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [announce] HVCS for inclusion in 2.6 tree
From
Date
On Thu, 2004-07-22 at 21:21, Andrew Morton wrote:
> > + retval = hvcs_get_partner_info(unit_address, &head, hvcs_pi_buff);
> > + if (retval) {
> > + printk(KERN_ERR "HVCS: Failed to fetch partner"
> > + " info for vty-server@%x.\n",unit_address);
> > + spin_lock_irqsave(&hvcs_pi_lock, flags);
>
> ^^ spin_unlock
>
> > + return retval;
> > + }
> > + spin_unlock_irqrestore(&hvcs_pi_lock, flags);
> >
>
> (Just move the spin_unlock() to be prior to the test of retval).
>
> Suggest you review all similar code in the patch for the same copy-n-paste
> bug.

Whoops! Thanks for catching that. I'll make sure it doesn't show up elsewhere.

Ryan S. Arnold
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:04    [W:0.096 / U:0.568 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site