Messages in this thread | | | Date | Sun, 02 Mar 2003 21:48:40 -0800 | From | Dan Kegel <> | Subject | Re: [PATCH] kernel source spellchecker |
| |
Steven Cole wrote: > BTW, I ran the spell-fix.pl script using only the first 10 entries > of spell-fix.txt (an arbitrary choice), and got a pretty big diff: > > 132 files changed, 199 insertions(+), 199 deletions(-) > > My feeling is that patches should be about 1/4 that size. > Otherwise, Linus may /dev/null them. Second opinion anyone?
I agree with the 1/4th, but in # of lines of spell-fix.txt, not in output size.
Looking at the changesets he's accepted, it looks like he's comfortable with changesets of 100 files (see "don't" fixes at http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/cset-1.1025.1.38.txt ) It probably helps that this was a single kind of change.
My guess is these things need enough manual reviewing that keeping it down to just a related group of fixes per patch is a good idea (e.g. Acknowledge=Acknowlege acknowledged=acknoledged together are a Good Idea, more is probably bad).
BTW Linus has been accepting so many spell fixes it's probably important to work with very fresh sources... - Dan
-- Dan Kegel http://www.kegel.com http://counter.li.org/cgi-bin/runscript/display-person.cgi?user=78045
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |