Messages in this thread | | | Date | Sun, 07 Jul 2002 16:31:25 -0700 | From | Dave Hansen <> | Subject | Re: BKL removal |
| |
Oliver Neukum wrote: >>BKL use isn't right or wrong -- it isn't a case of creating a deadlock >>or a race. I'm picking a relatively random function from "grep -r >>lock_kernel * | grep /usb/". I'll show what I think isn't optimal >>about it. > > Perhaps, we could agree that the BKL is used wrongly if it > won't fulfill its presumed function, or fulfills another function > than the obvious without a comment stating that, or fulfills > a non obvious function without any comment ?
I wouldn't want to make comments the qualifier for correct use, because that makes large chunks of the kernel "wrong" for lack of comments. In a development series we also don't want to restrict ourselves to changes of things that are wrong. We can also improve things that are bad.
-- Dave Hansen haveblue@us.ibm.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |