lkml.org 
[lkml]   [2002]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] 2.5: push BKL out of llseek

    On 29 Jan 2002, Robert Love wrote:
    >
    > Another gain from pushing the locks into each method is that we can pick
    > and choose as-needed. If it turns out inode semaphore is a global
    > solution, the following patch is sufficient. Otherwise, we could
    > replace the lock_kernel in each caller with the inode semaphore, as
    > appropriate. Oh Al ??

    Doing it in the low-level filesystem would match how we now do it inside
    generic_file_write() - ie the locking is done by the low-level filesystem,
    but most low-level filesystems choose to use a generic helper function.

    And I think your patch is slightly wrong:

    > + down(&file->f_dentry->d_inode->i_sem);

    That should really be:

    file->f_dentry->d_inode->i_mapping->host->i_sem

    to get the hosted filesystem case right (ie coda).

    Linus

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 13:15    [W:0.029 / U:29.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site