![]() | |||||||||||||
Messages in this thread |
On Tue, 29 Jan 2002, Linus Torvalds wrote: > > On 29 Jan 2002, Robert Love wrote: > > > > This patch pushes the BKL out of llseek() and into the individual llseek > > methods. For generic_file_llseek, I replaced it with the inode > > semaphore. > > Thinking about that, that actally sounds like the _right_ thing to do even > from a correctness standpoint - as llseek() looks at the inode size, so we > should have that lock anyway. > > So I'd suggest doing the inode semaphore globally, instead of using > kernel_lock at all. > > Al? It's OK for regular files and directories, but I'm not sure about devices. So I'd prefer to do it in two stages - shift BKL into ->llseek() and then see where it can be dropped/replaced with ->i_sem. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||||
| Last update: 2005-03-22 12:15 [from the cache] ©2003-2008 | |||||||||||||