Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | Date | Sat, 4 May 2024 14:25:43 +0300 | From | Dan Carpenter <> | Subject | [PATCH] Bluetooth: qca: Fix error code in qca_read_fw_build_info() |
| |
Return -ENOMEM on allocation failure. Don't return success.
Fixes: cfc2a7747108 ("Bluetooth: qca: fix info leak when fetching fw build id") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/bluetooth/btqca.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c index cc61014ffbc9..3b018ee33725 100644 --- a/drivers/bluetooth/btqca.c +++ b/drivers/bluetooth/btqca.c @@ -136,8 +136,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev) } build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL); - if (!build_label) + if (!build_label) { + err = -ENOMEM; goto out; + } hci_set_fw_info(hdev, "%s", build_label); -- 2.43.0
| ![\](/images/icornerr.gif) |