lkml.org 
[lkml]   [2024]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net] net: fec: remove .ndo_poll_controller to avoid deadlocks
From
Date
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 11 May 2024 14:20:09 +0800 you wrote:
> There is a deadlock issue found in sungem driver, please refer to the
> commit ac0a230f719b ("eth: sungem: remove .ndo_poll_controller to avoid
> deadlocks"). The root cause of the issue is that netpoll is in atomic
> context and disable_irq() is called by .ndo_poll_controller interface
> of sungem driver, however, disable_irq() might sleep. After analyzing
> the implementation of fec_poll_controller(), the fec driver should have
> the same issue. Due to the fec driver uses NAPI for TX completions, the
> .ndo_poll_controller is unnecessary to be implemented in the fec driver,
> so fec_poll_controller() can be safely removed.
>
> [...]

Here is the summary with links:
- [net] net: fec: remove .ndo_poll_controller to avoid deadlocks
https://git.kernel.org/netdev/net/c/c2e0c58b25a0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



\
 
 \ /
  Last update: 2024-05-27 18:26    [W:0.018 / U:1.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site