Messages in this thread | | | Date | Tue, 23 Apr 2024 12:45:06 -0600 | Subject | Re: [PATCH v4 2/3] bus: mhi: host: Add a new API for getting channel doorbell address | From | Jeffrey Hugo <> |
| |
On 4/23/2024 4:33 AM, Qiang Yu wrote: > Some controllers may want to know the address of a certain doorbell. Hence > add a new API where we read CHDBOFF register to get the base address of > doorbell, so that the controller can calculate the address of the doorbell > it wants by adding additional offset. > > Signed-off-by: Qiang Yu <quic_qianyu@quicinc.com> > diff --git a/include/linux/mhi.h b/include/linux/mhi.h > index d968e1a..cb3b676 100644 > --- a/include/linux/mhi.h > +++ b/include/linux/mhi.h > @@ -816,4 +816,10 @@ int mhi_queue_skb(struct mhi_device *mhi_dev, enum dma_data_direction dir, > */ > bool mhi_queue_is_full(struct mhi_device *mhi_dev, enum dma_data_direction dir); > > +/** > + * mhi_get_channel_doorbell_offset - Get the channel doorbell offset > + * @mhi_cntrl: MHI controller > + * @chdb_offset: Channel doorbell offset > + */ > +int mhi_get_channel_doorbell_offset(struct mhi_controller *mhi_cntrl, u32 *chdb_offset);
Should have a blank line here before the #endif just like how the file was before this change
> #endif /* _MHI_H_ */
With the above Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
| |