Messages in this thread | | | Date | Thu, 18 Apr 2024 22:55:23 +0200 (CEST) | From | Julia Lawall <> | Subject | Re: [cocci] [PATCH] coccinelle: misc: minmax: Suppress reports for err returns |
| |
On Mon, 15 Apr 2024, Ricardo Ribalda wrote:
> Most of the people prefer: > > return ret < 0 ? ret: 0; > > than: > > return min(ret, 0); > > Let's tweak the cocci file to ignore those lines completely. > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Applied, thanks. (Coccinelle for-6.10 branch).
julia
> --- > Following discussion at: > https://lore.kernel.org/linux-media/20240415203304.GA3460978@ragnatech.se/T/#m4dce34572312bd8a02542d798f21af7e4fc05fe8 > --- > scripts/coccinelle/misc/minmax.cocci | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/scripts/coccinelle/misc/minmax.cocci b/scripts/coccinelle/misc/minmax.cocci > index fcf908b34f27..ca4830ae3042 100644 > --- a/scripts/coccinelle/misc/minmax.cocci > +++ b/scripts/coccinelle/misc/minmax.cocci > @@ -50,11 +50,26 @@ func(...) > ...> > } > > +// Ignore errcode returns. > +@errcode@ > +position p; > +identifier func; > +expression x; > +binary operator cmp = {<, <=}; > +@@ > + > +func(...) > +{ > + <... > + return ((x) cmp@p 0 ? (x) : 0); > + ...> > +} > + > @rmin depends on !patch@ > identifier func; > expression x, y; > binary operator cmp = {<, <=}; > -position p; > +position p != errcode.p; > @@ > > func(...) > @@ -116,21 +131,6 @@ func(...) > ...> > } > > -// Don't generate patches for errcode returns. > -@errcode depends on patch@ > -position p; > -identifier func; > -expression x; > -binary operator cmp = {<, <=}; > -@@ > - > -func(...) > -{ > - <... > - return ((x) cmp@p 0 ? (x) : 0); > - ...> > -} > - > @pmin depends on patch@ > identifier func; > expression x, y; > > --- > base-commit: 71b3ed53b08d87212fbbe51bdc3bf44eb8c462f8 > change-id: 20240415-minimax-1e9110d4697b > > Best regards, > -- > Ricardo Ribalda <ribalda@chromium.org> > >
| |