Messages in this thread | | | Date | Sun, 14 Apr 2024 15:01:14 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents. |
| |
The subject is too vague.
On Sun, Apr 14, 2024 at 05:21:06PM +0530, sumadhura kalyan wrote: > Issue found by checkpatch ^^^^^^^^^^^^^^^^^^^^^^^^^ What issue?
A better commit message would be:
================== Subject: [PATCH v3] staging: vc04_services: re-align function parameters
Checkpatch complains that:
CHECK: Lines should not end with a '(' #45: FILE: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h:45: +typedef void (*vchiq_mmal_buffer_cb)(
Re-align the function parameters to make checkpatch happy. ================
> > Signed-off-by: sumadhura kalyan <opensourcecond@gmail.com> ^ ^ You should make these capital letters... It's supposed to look formal like you're signing a legal document.
regards, dan carpenter
| |