Messages in this thread | | | Date | Wed, 20 Mar 2024 21:16:56 +0100 | From | Sebastian Reichel <> | Subject | Re: [PATCH 2/4] media: dt-binding: media: Document rk35 88’s vepu121 |
| |
Hi,
On Wed, Mar 20, 2024 at 06:37:31PM +0100, Emmanuel Gil Peyrot wrote: > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > --- > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > index 9d90d8d0565a..947ad699cc5e 100644 > --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml > @@ -17,6 +17,7 @@ properties: > compatible: > enum: > - rockchip,rk3568-vepu > + - rockchip,rk3588-vepu121
Looks like they are fully compatible. In that case it's better to use a fallback compatible (i.e. like the iommu binding), which does not need any drivers changes. So binding should be like this:
compatible: oneOf: - const: rockchip,rk3568-vepu - items: - enum: - rockchip,rk3588-vepu121 - const: rockchip,rk3568-vepu
Then in DT (i.e. the following patch) you use
compatible = "rockchip,rk3588-vepu121", "rockchip,rk3568-vepu";
And patch 4/4 can be dropped.
Greetings,
-- Sebastian [unhandled content-type:application/pgp-signature] | |