Messages in this thread | | | Date | Wed, 13 Mar 2024 21:01:55 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/6] iio: pressure: Simplify read_* functions |
| |
On Wed, Mar 13, 2024 at 06:40:03PM +0100, Vasileios Amoiridis wrote:
In the Subject: ... read_*() functions
> Add the coefficients for the IIO standard units inside the chip_info > structure. > > Remove the calculations with the coefficients for the IIO compatibility > from inside the read_(temp/press/humid) functions and move it to the
read_{temp,press,humid}()
> read_raw function.
read_raw()
> Execute the calculations with the coefficients inside the read_raw
read_raw()
> oneshot capture functions. > > Also fix raw_* and comp_* values signs.
..
> case IIO_TEMP: > - ret = data->chip_info->read_temp(data, val, val2); > + ret = data->chip_info->read_temp(data); > + *val = data->chip_info->temp_coeffs[0] * ret; > + *val2 = data->chip_info->temp_coeffs[1];
> + if (!strcmp(indio_dev->name, "bmp580")) > + ret = IIO_VAL_FRACTIONAL_LOG2; > + else > + ret = IIO_VAL_FRACTIONAL;
I'm wondering if we may replace these strcmp():s by using enum and respective values in chip_info.
> break;
-- With Best Regards, Andy Shevchenko
| |