Messages in this thread | | | Date | Wed, 13 Mar 2024 21:04:46 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 4/6] iio: pressure: Simplify and make more clear temperature readings |
| |
On Wed, Mar 13, 2024 at 06:40:05PM +0100, Vasileios Amoiridis wrote: > The read_press/read_humid functions need the updated t_fine value
read_press()/read_humid()
> in order to calculate the current pressure/humidity. Temperature > reads should be removed from the read_press/read_humid functions
read_press()/read_humid()
> and should be placed in the oneshot captures before the pressure > and humidity reads. This makes the code more intuitive.
..
> + if (strcmp(indio_dev->name, "bmp580")) > + data->chip_info->read_temp(data); > +
> + if (strcmp(indio_dev->name, "bmp580")) > + data->chip_info->read_temp(data);
Yeah, not a fan of the strcmp().
-- With Best Regards, Andy Shevchenko
| |