Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 7 Feb 2024 20:15:43 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests |
| |
On Wed, Feb 07, 2024 at 04:22:49PM -0800, Charlie Jenkins wrote: > The ip_fast_csum and csum_ipv6_magic tests did not have the data > types properly casted, and improperly misaligned data. > > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
I still get:
Failed unit tests: mips:malta:checksum mips64:malta:checksum mipsel:malta:checksum mipsel64:malta:checksum parisc:B160L:checksum parisc:C3700:checksum parisc64:C3700:checksum sh:rts7751r2dplus_defconfig:checksum
on parisc/parisc64:
# test_ip_fast_csum: ASSERTION FAILED at lib/checksum_kunit.c:463 Expected ( u64)csum_result == ( u64)expected, but ( u64)csum_result == 33754 (0x83da) ( u64)expected == 10946 (0x2ac2) not ok 4 test_ip_fast_csum ok 5 test_csum_ipv6_magic # checksum: pass:4 fail:1 skip:0 total:5 # Totals: pass:4 fail:1 skip:0 total:5
mipsel/mipsel64 (little endian):
# test_csum_ipv6_magic: ASSERTION FAILED at lib/checksum_kunit.c:506 Expected ( u64)csum_result == ( u64)expected, but ( u64)csum_result == 18588 (0x489c) ( u64)expected == 12357 (0x3045) not ok 5 test_csum_ipv6_magic # checksum: pass:4 fail:1 skip:0 total:5 # Totals: pass:4 fail:1 skip:0 total:5
mips (big endian):
# test_csum_ipv6_magic: ASSERTION FAILED at lib/checksum_kunit.c:506 Expected ( u64)csum_result == ( u64)expected, but ( u64)csum_result == 59728 (0xe950) ( u64)expected == 12357 (0x3045) not ok 5 test_csum_ipv6_magic # checksum: pass:4 fail:1 skip:0 total:5 # Totals: pass:4 fail:1 skip:0 total:5
I noticed that csum_result varies across tests for some reason. On parisc/parisc64 the value is unexpected but always the same.
sh (little endian; ok, this isn't entirely fair, this test wasn't enabled before):
KTAP version 1 # Subtest: checksum # module: checksum_kunit 1..5 # test_csum_fixed_random_inputs: ASSERTION FAILED at lib/checksum_kunit.c:370 Expected ( u64)result == ( u64)expec, but ( u64)result == 53378 (0xd082) ( u64)expec == 33488 (0x82d0) not ok 1 test_csum_fixed_random_inputs # test_csum_all_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:395 Expected ( u64)result == ( u64)expec, but ( u64)result == 65281 (0xff01) ( u64)expec == 65280 (0xff00) not ok 2 test_csum_all_carry_inputs # test_csum_no_carry_inputs: ASSERTION FAILED at lib/checksum_kunit.c:443 Expected ( u64)result == ( u64)expec, but ( u64)result == 65535 (0xffff) ( u64)expec == 65534 (0xfffe) not ok 3 test_csum_no_carry_inputs ok 4 test_ip_fast_csum ok 5 test_csum_ipv6_magic # checksum: pass:2 fail:3 skip:0 total:5 # Totals: pass:2 fail:3 skip:0 total:5
The result/expected values are always the same in the sh4 tests. I'd take the test results for sh4 with a grain of salt; there is at least some possibility that this is an emulation problem.
Guenter
| ![\](/images/icornerr.gif) |