Messages in this thread | | | Date | Wed, 7 Feb 2024 18:09:53 -0800 | From | Charlie Jenkins <> | Subject | Re: [PATCH v6 0/2] lib: checksum: Fix issues with checksum tests |
| |
On Wed, Feb 07, 2024 at 05:45:22PM -0800, Andrew Morton wrote: > On Wed, 07 Feb 2024 16:22:49 -0800 Charlie Jenkins <charlie@rivosinc.com> wrote: > > > The ip_fast_csum and csum_ipv6_magic tests did not have the data > > types properly casted, and improperly misaligned data. > > Neither this nor the two patch's changelogs describe *why* these changes > are needed. They merely assert that we need to do this. > > IOW, when fixing a bug please always describe the user-visible effects > of that bug. >
I can add a description that says that the tests are being fixed because they caused failures on systems without misaligned access support. As for the casting patch it's a bit less pertinent but I can add that it allows the code to pass sparse checks.
- Charlie
| |