Messages in this thread | | | From | Oleksij Rempel <> | Subject | [PATCH net-next v7 0/8] net: ethernet: Rework EEE | Date | Thu, 29 Feb 2024 15:07:52 +0100 |
| |
Hello all,
with Andrew's permission I'll continue mainlining this patches:
==============================================================
Most MAC drivers get EEE wrong. The API to the PHY is not very obvious, which is probably why. Rework the API, pushing most of the EEE handling into phylib core, leaving the MAC drivers to just enable/disable support for EEE in there change_link call back.
MAC drivers are now expect to indicate to phylib if they support EEE. This will allow future patches to configure the PHY to advertise no EEE link modes when EEE is not supported. The information could also be used to enable SmartEEE if the PHY supports it.
With these changes, the uAPI configuration eee_enable becomes a global on/off. tx-lpi must also be enabled before EEE is enabled. This fits the discussion here:
https://lore.kernel.org/netdev/af880ce8-a7b8-138e-1ab9-8c89e662eecf@gmail.com/T/
This patchset puts in place all the infrastructure, and converts one MAC driver to the new API. Following patchsets will convert other MAC drivers, extend support into phylink, and when all MAC drivers are converted to the new scheme, clean up some unneeded code.
v7: -- add phy_link_down() before phy_link_up() rewrite comment for phy_ethtool_set_eee_noneg() add check for changed tx_lpi_timer
v6: -- Reword different comments. See per patch change comments.
v5: -- Rebase against latest netdev-next Use keee instead of eee struct
v4 -- Only convert one MAC driver Drop all phylink code Conform to the uAPI discision.
v3 -- Rework phylink code to add a new callback. Rework function to indicate clock should be stopped during LPI
Andrew Lunn (7): net: phy: Add phydev->enable_tx_lpi to simplify adjust link callbacks net: phy: Add helper to set EEE Clock stop enable bit net: phy: Keep track of EEE configuration net: phy: Immediately call adjust_link if only tx_lpi_enabled changes net: phy: Add phy_support_eee() indicating MAC support EEE net: fec: Move fec_enet_eee_mode_set() and helper earlier net: fec: Fixup EEE
Russell King (1): net: add helpers for EEE configuration
drivers/net/ethernet/freescale/fec_main.c | 84 ++++++++++------------- drivers/net/phy/phy-c45.c | 14 +++- drivers/net/phy/phy.c | 68 +++++++++++++++++- drivers/net/phy/phy_device.c | 28 ++++++++ include/linux/phy.h | 9 ++- include/net/eee.h | 38 ++++++++++ 6 files changed, 187 insertions(+), 54 deletions(-) create mode 100644 include/net/eee.h
-- 2.39.2
| |