Messages in this thread Patch in this message | | | From | Bjorn Helgaas <> | Subject | [PATCH] drm/fsl-dcu: remove unnecessary NULL checks | Date | Thu, 29 Feb 2024 12:14:04 -0600 |
| |
From: Bjorn Helgaas <bhelgaas@google.com>
The power management callbacks are never called unless .probe() has already returned success, which means it has set drvdata to a non-NULL pointer, so "dev" can never be NULL in the other callbacks.
Remove the unnecessary checks.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c index ab6c0c6cd0e2..ca23a2ca16bb 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c @@ -170,9 +170,6 @@ static int fsl_dcu_drm_pm_suspend(struct device *dev) struct fsl_dcu_drm_device *fsl_dev = dev_get_drvdata(dev); int ret; - if (!fsl_dev) - return 0; - disable_irq(fsl_dev->irq); ret = drm_mode_config_helper_suspend(fsl_dev->drm); @@ -191,9 +188,6 @@ static int fsl_dcu_drm_pm_resume(struct device *dev) struct fsl_dcu_drm_device *fsl_dev = dev_get_drvdata(dev); int ret; - if (!fsl_dev) - return 0; - ret = clk_prepare_enable(fsl_dev->clk); if (ret < 0) { dev_err(dev, "failed to enable dcu clk\n"); -- 2.34.1
| |