Messages in this thread | | | Date | Thu, 29 Feb 2024 19:01:47 +0100 | Subject | Re: [PATCH v5 1/7] dt-bindings: iommu: Add Qualcomm TBU bindings | From | Krzysztof Kozlowski <> |
| |
On 26/02/2024 18:22, Georgi Djakov wrote: > The "apps_smmu" on the Qualcomm sdm845 platform is an implementation > of the SMMU-500, that consists of a single TCU (Translation Control > Unit) and multiple TBUs (Translation Buffer Units). These TBUs have > hardware debugging features that are specific and only present on > Qualcomm hardware. Represent them as independent DT nodes. List all > the resources that are needed to operate them (such as registers, > clocks, power domains and interconnects). > > Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com>
Also one more nit, since I expect new version:
A nit, subject: drop second/last, redundant "bindings". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards, Krzysztof
| |