Messages in this thread | | | Date | Thu, 29 Feb 2024 22:14:11 +0200 | Subject | Re: [PATCH v5 7/7] arm64: dts: qcom: sc7280: Add DT nodes for the TBUs | From | Georgi Djakov <> |
| |
Hi Krzysztof,
On 29.02.24 19:55, Krzysztof Kozlowski wrote: > On 26/02/2024 18:22, Georgi Djakov wrote: >> Add the device-tree nodes for the TBUs (translation buffer units) that >> are present on the sc7280 platforms. The TBUs can be used debug the >> kernel and provide additional information when a context faults occur. >> >> Describe the all registers, clocks, interconnects and power-domain >> resources that are needed for each of the TBUs. >> >> Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sc7280.dtsi | 89 ++++++++++++++++++++++++++++ >> 1 file changed, 89 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> index 83b5b76ba179..cc42560f63ad 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi >> @@ -2905,6 +2905,18 @@ adreno_smmu: iommu@3da0000 { >> dma-coherent; >> }; >> >> + gfx_0_tbu: tbu@3dd9000 { >> + compatible = "qcom,qsmmuv500-tbu"; >> + reg = <0x0 0x3dd9000 0x0 0x1000>; >> + qcom,stream-id-range = <&adreno_smmu 0x0 0x400>; > > Where are the clocks/interconnects/power-domains? Your binding said it > is exactly (100%) the same as SDM845, so either binding is missing > compatibles or this is incomplete.
The clocks/interconnects/power-domains are optional and each of them could be present or not. And that's why none of these properties are listed as "required".
BR, Georgi
| |