Messages in this thread | | | From | Masahiro Yamada <> | Subject | [PATCH 0/1] MIPS: fix the "CPU type" choice structure | Date | Sun, 28 Jan 2024 01:23:08 +0900 |
| |
The bool type "choice" is meant to list exclusively selected config options.
Unless you are familiar with the Kconfig internals, you will not understand how CONFIG_B can be enabled in the following code:
choice prompt "Choose one of them, but how to choose B?"
config A bool "A"
config B bool "B" depends on A
config C bool "C"
endchoice
B is not a choice value because it becomes a child of A, as a side-effect of re-paranting in menu_finalize(). It is unreadable, and I even consider it as a bug. My plan is to forbid such a silly choice structure.
Just write as follows:
choice prompt "Choose one of them"
config A bool "A"
config C bool "C"
endchoice
config B bool "B" depends on A
Fortunately, arch/mips/Kconfig seems to be the only file I need to fix.
Masahiro Yamada (1): MIPS: move unselectable entries out of the "CPU type" choice
arch/mips/Kconfig | 76 +++++++++++++++++++++++------------------------ 1 file changed, 38 insertions(+), 38 deletions(-)
-- 2.40.1
| |