Messages in this thread | | | From | Suman Ghosh <> | Subject | RE: [EXT] [net-next: PATCH] net: mvpp2: initialize port fwnode pointer | Date | Tue, 2 Jan 2024 06:35:37 +0000 |
| |
Looks good to me.
>---------------------------------------------------------------------- >Update the port's device structure also with its fwnode pointer with a >recommended device_set_node() helper routine. > >Signed-off-by: Marcin Wojtas <marcin.s.wojtas@gmail.com> [Suman] Reviewed-by: Suman Ghosh <sumang@marvell.com> >--- > drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >index 1ca273f17d29..820b1fabe297 100644 >--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c >@@ -6877,7 +6877,7 @@ static int mvpp2_port_probe(struct platform_device >*pdev, > dev->min_mtu = ETH_MIN_MTU; > /* 9704 == 9728 - 20 and rounding to 8 */ > dev->max_mtu = MVPP2_BM_JUMBO_PKT_SIZE; >- dev->dev.of_node = port_node; >+ device_set_node(&dev->dev, port_fwnode); > > port->pcs_gmac.ops = &mvpp2_phylink_gmac_pcs_ops; > port->pcs_gmac.neg_mode = true; >-- >2.34.1 >
| |