Messages in this thread | | | Date | Mon, 15 Jan 2024 21:25:57 +0800 | Subject | Re: [PATCH -next v4 0/3] minor improvements for x86 mce processing | From | Kefeng Wang <> |
| |
Hi Borislav and Tony,
On 2024/1/11 21:55, Tong Tiangen wrote: > In this patchset, we remove the unused macro EX_TYPE_COPY and centralize > the processing of memory-failure to do_machine_check() to avoid calling > memory_failure_queue() separately for different MC-Safe scenarios. In > addition, MCE_IN_KERNEL_COPYIN is renamed MCE_IN_KERNEL_COPY_MC to expand > its usage scope.
The patchset is a followup[1], as Borislav suggested[2], we firstly cleanup unused EX_TYPE_COPY, then rename MCE_IN_KERNEL_COPYIN to reduce confusion, could you give us some comments about it, many thanks.
> > [1]https://lore.kernel.org/linux-mm/20230526063242.133656-1-wangkefeng.wang@huawei.com/ > [2] https://lore.kernel.org/linux-edac/20230602160138.GDZHoSYsWoPAinMszk@fat_crate.local/ > since v3: > 1. Rebased on linux-next tag next-20240111. > 2. Delete duplicate commit references on patch 3. > > since v2: > 1. remove redundant fixup type EX_TYPE_COPY. > 2. rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC. > 3. update patch3's commit message and the processing logic of > EX_TYPE_DEFAULT_MCE_SAFE based on the discussion of [1]. > > Kefeng Wang (1): > x86/mce: set MCE_IN_KERNEL_COPY_MC for DEFAULT_MCE_SAFE exception > > Tong Tiangen (2): > x86/mce: remove redundant fixup type EX_TYPE_COPY > x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC > > arch/x86/include/asm/asm.h | 3 --- > arch/x86/include/asm/extable_fixup_types.h | 23 +++++++++++----------- > arch/x86/include/asm/mce.h | 8 ++++---- > arch/x86/kernel/cpu/mce/core.c | 2 +- > arch/x86/kernel/cpu/mce/severity.c | 7 +++---- > arch/x86/mm/extable.c | 9 --------- > mm/ksm.c | 1 - > mm/memory.c | 13 ++++-------- > 8 files changed, 23 insertions(+), 43 deletions(-) >
| |