Messages in this thread | | | From | Pankaj Gupta <> | Subject | RE: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure enclave firmware | Date | Tue, 8 Aug 2023 11:07:55 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Thursday, July 13, 2023 12:08 AM > To: Pankaj Gupta <pankaj.gupta@nxp.com>; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; clin@suse.com; > conor+dt@kernel.org; pierre.gondois@arm.com; Jacky Bai > <ping.bai@nxp.com>; Clark Wang <xiaoning.wang@nxp.com>; Wei Fang > <wei.fang@nxp.com>; Peng Fan <peng.fan@nxp.com>; Bough Chen > <haibo.chen@nxp.com>; festevam@gmail.com; dl-linux-imx <linux- > imx@nxp.com>; davem@davemloft.net; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; linux-arm-kernel@lists.infradead.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; Gaurav Jain > <gaurav.jain@nxp.com>; alexander.stein@ew.tq-group.com; Sahil Malhotra > <sahil.malhotra@nxp.com>; Aisheng Dong <aisheng.dong@nxp.com>; Varun > Sethi <V.Sethi@nxp.com> > Subject: [EXT] Re: [PATCH v4 2/7] arm64: dts: imx8ulp-evk: added nxp secure > enclave firmware > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 12/07/2023 14:12, Pankaj Gupta wrote: > > Added support for NXP secure enclave called EdgeLock Enclave firmware > > (se-fw) for imx8ulp-evk. > > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > index 3ddc0f3125b3..10ed31974a6f 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > @@ -114,7 +114,7 @@ sosc: clock-sosc { > > #clock-cells = <0>; > > }; > > > > - sram@2201f000 { > > + sram0: sram@2201f000 { > > compatible = "mmio-sram"; > > reg = <0x0 0x2201f000 0x0 0x1000>; > > > > @@ -161,6 +161,16 @@ s4muap: mailbox@27020000 { > > #mbox-cells = <2>; > > }; > > > > + ele_fw: se-fw { > > + compatible = "fsl,imx-ele"; > > + mboxes = <&s4muap 0 0 &s4muap 1 0>; > > + mbox-names = "tx", "rx"; > > + fsl,mu-did = <7>; > > + fsl,mu-id = <2>; > > + sram-pool = <&sram0>; > > It does not look like you tested the DTS against bindings. Please run `make > dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or > https://www.li/ > naro.org%2Fblog%2Ftips-and-tricks-for-validating-devicetree-sources-with- > the-devicetree- > schema%2F&data=05%7C01%7Cpankaj.gupta%40nxp.com%7Cd13d0b68d01c > 4d10d8cb08db83070ed2%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0% > 7C0%7C638247838553225400%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC > 4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7 > C%7C%7C&sdata=pO6dnz4aPqVejRNDR0OU4n04hXebyqgrNKg4DPhahI0%3D > &reserved=0 > for instructions).
Tested. Before submitting the patch. [Pankaj] Accepted.
> > > + status = "okay"; > > It's by default. > Will be removed from the V5. > Best regards, > Krzysztof
| |