Messages in this thread | | | Date | Mon, 7 Aug 2023 23:48:24 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY |
| |
> That wording of "match downstream sources" is amiguous, sorry. > > What I meant was that: > > 1. This looks like a properly formatted dtsi node, follows > conventions in the file for ordering, etc > 2. The downstream devicetree from Qualcomm uses the same MMIO region > same dependencies for clocks, etc. I do not have documentation > to further review past that
O.K. This does make your reviews worthwhile.
Vendor crap gets that name for a reason. So just saying it is the same as the vendor code is not really helpful. So i would avoid this ambiguous statement. And your later comment on a patch which points out real problems adds to my confidence you did a real review.
Thanks Andrew
| |