Messages in this thread | | | Date | Mon, 7 Aug 2023 16:39:01 -0500 | From | Andrew Halaney <> | Subject | Re: [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY |
| |
On Mon, Aug 07, 2023 at 11:28:15PM +0200, Andrew Lunn wrote: > On Mon, Aug 07, 2023 at 04:10:34PM -0500, Andrew Halaney wrote: > > On Mon, Aug 07, 2023 at 09:34:59PM +0200, Bartosz Golaszewski wrote: > > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > > > Add a node for the SerDes PHY used by EMAC1 on sa8775p-ride. > > > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > FWIW this seems to match downstream sources. > > > > Reviewed-by: Andrew Halaney <ahalaney@redhat.com> > > Why does matching downstream make it correct and deserve a > Reviewed-by? > > Did you actually review the change? > > Andrew >
That wording of "match downstream sources" is amiguous, sorry.
What I meant was that:
1. This looks like a properly formatted dtsi node, follows conventions in the file for ordering, etc 2. The downstream devicetree from Qualcomm uses the same MMIO region same dependencies for clocks, etc. I do not have documentation to further review past that
I didn't suspect anyone else would cross check this information, so I did and thought it deserves a RB after that. Please let me know if you'd rather I just leave a comment saying such without any formal tags (but I thought since the whole patch looks proper and that information looks correct compared to the "documentation" I have access to it deserved such).
In the rest of this series review I may have used similar phrasing with respect to downstream, but that expanded description is what I meant in those cases as well.
Thanks, Andrew
| |