Messages in this thread | | | Date | Fri, 21 Jul 2023 17:35:15 +0800 | Subject | Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC | From | Guo Samin <> |
| |
on 2023/7/21 17:16:41, Conor Dooley wrote: > On Fri, Jul 21, 2023 at 03:27:33PM +0800, Guo Samin wrote: > >> Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC >> From: Conor Dooley <conor@kernel.org> > >> to: Guo Samin <samin.guo@starfivetech.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Paul Walmsley <paul.walmsley@sifive.com>, Palmer Dabbelt <palmer@dabbelt.com>, Albert Ou <aou@eecs.berkeley.edu>, Hal Feng <hal.feng@starfivetech.com>, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org >> data: 2023/7/21 > > btw, please try and remove this stuff from your mails. >
Sure
>>> On 21 July 2023 03:09:19 IST, Guo Samin <samin.guo@starfivetech.com> wrote: > >>>> There is a question about the configuration of phy that I would like to consult you. >>>> >>>> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice >>>> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp . >>>> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again. >>>> >>>> Should I submit another pacthes based on riscv-dt-for-next? >>> >>> Huh, dtbs_check passed for these patches, >>> I didn't realise changes to the motorcomm stuff >>> were a dep. for this. I'll take a look later. > >> After discussing with HAL, I have prepared the code and considered adding the following patch to >> Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1]) >> which will then send patches based on linux-next. What do you think? @Andrew @Conor > > I think you are better off just sending the dts patch to me, adding a > dts patch that will not apply to net-next to your motorcomm driver series > will only really cause problems for the netdev patchwork automation. >
Okay, I'll send you DTS separately.
>> [1] https://patchwork.kernel.org/project/netdevbpf/cover/20230720111509.21843-1-samin.guo@starfivetech.com > > I meant to ack this yesterday, but it wasn't in my dt-binding review > queue. I'll go do that now.
Best regards, Samin
| |