Messages in this thread | ![/](/images/icornerl.gif) | | From | "Ng, Boon Khai" <> | Subject | RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload | Date | Fri, 21 Jul 2023 16:39:10 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Saturday, July 22, 2023 12:26 AM > To: Ng, Boon Khai <boon.khai.ng@intel.com>; Boon@ecsmtp.png.intel.com; > Khai@ecsmtp.png.intel.com; Giuseppe Cavallaro <peppe.cavallaro@st.com>; > Alexandre Torgue <alexandre.torgue@foss.st.com>; Jose Abreu > <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>; Eric > Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; > Paolo Abeni <pabeni@redhat.com>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; netdev@vger.kernel.org; linux-stm32@st- > md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Cc: Shevchenko, Andriy <andriy.shevchenko@intel.com>; Tham, Mun Yew > <mun.yew.tham@intel.com>; Swee, Leong Ching > <leong.ching.swee@intel.com>; G Thomas, Rohan > <rohan.g.thomas@intel.com>; Shevchenko Andriy > <andriy.shevchenko@linux.intel.com> > Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt- > bindings: net: snps,dwmac: Add description for rx-vlan-offload > > On 21/07/2023 17:28, Ng, Boon Khai wrote: > > This is a new device bringup, thus the DT is not available yet. The > > DTS will be upstreamed by my another colleague, unless, if I can upstream > only my part on the setting? > > > >> Please kindly resend and include all necessary To/Cc entries. > > To be clear, since you do not agree with my comment you skipped vital lists, > this was not tested by automation so it is NAK from me. > > Sorry. >
I understand that I already get a NAK at the beginning. But I don’t understand why, Please don’t get me wrong, I'm not disagreeing your comments, was trying to understand the reason behind and also which are the step that I made a mistake(s) on, this is to help me to learn at the same time to smoothen the upstreaming process.
> Best regards, > Krzysztof
| ![\](/images/icornerr.gif) |