Messages in this thread | | | From | "Ng, Boon Khai" <> | Subject | RE: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt-bindings: net: snps,dwmac: Add description for rx-vlan-offload | Date | Fri, 21 Jul 2023 16:33:51 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Saturday, July 22, 2023 12:22 AM > To: Ng, Boon Khai <boon.khai.ng@intel.com>; Boon@ecsmtp.png.intel.com; > Khai@ecsmtp.png.intel.com; Giuseppe Cavallaro <peppe.cavallaro@st.com>; > Alexandre Torgue <alexandre.torgue@foss.st.com>; Jose Abreu > <joabreu@synopsys.com>; David S . Miller <davem@davemloft.net>; Eric > Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; > Paolo Abeni <pabeni@redhat.com>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; netdev@vger.kernel.org; linux-stm32@st- > md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Cc: Shevchenko, Andriy <andriy.shevchenko@intel.com>; Tham, Mun Yew > <mun.yew.tham@intel.com>; Swee, Leong Ching > <leong.ching.swee@intel.com>; G Thomas, Rohan > <rohan.g.thomas@intel.com>; Shevchenko Andriy > <andriy.shevchenko@linux.intel.com> > Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt- > bindings: net: snps,dwmac: Add description for rx-vlan-offload > > On 21/07/2023 17:28, Ng, Boon Khai wrote: > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzk@kernel.org> > >> Sent: Friday, July 21, 2023 6:11 PM > >> To: Boon@ecsmtp.png.intel.com; Khai@ecsmtp.png.intel.com; "Ng > >> <boon.khai.ng"@intel.com; Giuseppe Cavallaro > >> <peppe.cavallaro@st.com>; Alexandre Torgue > >> <alexandre.torgue@foss.st.com>; Jose Abreu <joabreu@synopsys.com>; > >> David S . Miller <davem@davemloft.net>; Eric Dumazet > >> <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo > Abeni > >> <pabeni@redhat.com>; Maxime Coquelin > <mcoquelin.stm32@gmail.com>; > >> netdev@vger.kernel.org; linux-stm32@st-md- mailman.stormreply.com; > >> linux-arm-kernel@lists.infradead.org; linux- kernel@vger.kernel.org > >> Cc: Ng, Boon Khai <boon.khai.ng@intel.com>; Shevchenko, Andriy > >> <andriy.shevchenko@intel.com>; Tham, Mun Yew > >> <mun.yew.tham@intel.com>; Swee, Leong Ching > >> <leong.ching.swee@intel.com>; G Thomas, Rohan > >> <rohan.g.thomas@intel.com>; Shevchenko Andriy > >> <andriy.shevchenko@linux.intel.com> > >> Subject: Re: [Enable Designware XGMAC VLAN Stripping Feature 1/2] dt- > bindings: > >> net: snps,dwmac: Add description for rx-vlan-offload > >> > >> On 21/07/2023 08:26, Boon@ecsmtp.png.intel.com wrote: > >>> From: Boon Khai Ng <boon.khai.ng@intel.com> > >>> > >>> This patch is to add the dts setting for the MAC controller on > >>> synopsys 10G Ethernet MAC which allow the 10G MAC to turn on > >>> hardware accelerated VLAN stripping. Once the hardware accelerated > >>> VLAN stripping is turn on, the VLAN tag will be stripped by the > >> > >> Subject prefix is totally bogus. > >> > > > > Which part? It's a 10G Ethernet IP from Sysnopsys, in Roman character it is > X (mean 10), so XGMAC. > > Even the driver file I'm editing it is dw"xgmac". > > Everything in []. > > > > >> > >>> 10G Ethernet MAC. > >>> > >>> Signed-off-by: Boon Khai Ng <boon.khai.ng@intel.com> > >>> Reviewed-by: Shevchenko Andriy <andriy.shevchenko@linux.intel.com> > >> > >> Please use scripts/get_maintainers.pl to get a list of necessary > >> people and lists to CC. It might happen, that command when run on an > >> older kernel, gives you outdated entries. Therefore please be sure > >> you base your patches on recent Linux kernel. > >> > > > > This is based on net-next repository suggested by the get maintainer script. > > > > I got the latest net-next just now at the Commit-id b44693495af8 which > > just committed yesterday. > > > > $ ./scripts/get_maintainer.pl --scm -f > > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > > That's not how you run it. get_maintainers.pl should be run on patches or on > all files, not just some selection. > > > Giuseppe Cavallaro <peppe.cavallaro@st.com> (supporter:STMMAC > ETHERNET > > DRIVER) Alexandre Torgue <alexandre.torgue@foss.st.com> > > (supporter:STMMAC ETHERNET DRIVER) Jose Abreu > <joabreu@synopsys.com> > > (supporter:STMMAC ETHERNET DRIVER) "David S. Miller" > > <davem@davemloft.net> (maintainer:NETWORKING DRIVERS) Eric > Dumazet > > <edumazet@google.com> (maintainer:NETWORKING DRIVERS) Jakub > Kicinski > > <kuba@kernel.org> (maintainer:NETWORKING DRIVERS) Paolo Abeni > > <pabeni@redhat.com> (maintainer:NETWORKING DRIVERS) Maxime > Coquelin > > <mcoquelin.stm32@gmail.com> (maintainer:ARM/STM32 ARCHITECTURE) > > Richard Cochran <richardcochran@gmail.com> (maintainer:PTP HARDWARE > > CLOCK SUPPORT) netdev@vger.kernel.org (open list:STMMAC ETHERNET > > DRIVER) linux-stm32@st-md-mailman.stormreply.com (moderated > > list:ARM/STM32 ARCHITECTURE) linux-arm-kernel@lists.infradead.org > > (moderated list:ARM/STM32 ARCHITECTURE) linux-kernel@vger.kernel.org > > (open list) git > > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git > > git git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git > > git git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git > > stm32-next git > > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > > >> You missed at least DT list (maybe more), so this won't be tested by > >> automated tooling. Performing review on untested code might be a > >> waste of time, thus I will skip this patch entirely till you follow > >> the process allowing the patch to be tested. > >> > > > > This is a new device bringup, thus the DT is not available yet. The > > DTS will be upstreamed by my another colleague, unless, if I can upstream > only my part on the setting? > > You are mixing now DTS and DT bindings. Sorry, we do not talk about DTS. > > Follow our process of submitting patches. For sure there are folks in Intel > which can explain it to you. >
Ah see, so you were saying I'm missing the cc list of the maintainer related to the DT binding.
> > Best regards, > Krzysztof
| |