lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drm/loongson: Fix two warnings because of passing wrong type
Date
When accessing I/O memory, we should pass '__iomem *' type instead of
'void *' simply, otherwise sparse tests will complain. After applied
this patch, the following two sparse warnings got fixed.

1) drivers/gpu/drm/loongson/lsdc_benchmark.c:27:35:
sparse: expected void volatile [noderef] __iomem *
sparse: got void *kptr

2) drivers/gpu/drm/loongson/lsdc_benchmark.c:42:51:
sparse: expected void const volatile [noderef] __iomem *
sparse: got void *kptr

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202307100243.v3hv6aes-lkp@intel.com/
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/loongson/lsdc_benchmark.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/loongson/lsdc_benchmark.c b/drivers/gpu/drm/loongson/lsdc_benchmark.c
index b088646a2ff9..36e352820bdb 100644
--- a/drivers/gpu/drm/loongson/lsdc_benchmark.c
+++ b/drivers/gpu/drm/loongson/lsdc_benchmark.c
@@ -24,7 +24,7 @@ static void lsdc_copy_gtt_to_vram_cpu(struct lsdc_bo *src_bo,
lsdc_bo_kmap(dst_bo);

while (n--)
- memcpy_toio(dst_bo->kptr, src_bo->kptr, size);
+ memcpy_toio((void __iomem *)dst_bo->kptr, src_bo->kptr, size);

lsdc_bo_kunmap(src_bo);
lsdc_bo_kunmap(dst_bo);
@@ -39,7 +39,7 @@ static void lsdc_copy_vram_to_gtt_cpu(struct lsdc_bo *src_bo,
lsdc_bo_kmap(dst_bo);

while (n--)
- memcpy_fromio(dst_bo->kptr, src_bo->kptr, size);
+ memcpy_fromio(dst_bo->kptr, (void __iomem *)src_bo->kptr, size);

lsdc_bo_kunmap(src_bo);
lsdc_bo_kunmap(dst_bo);
--
2.34.1
\
 
 \ /
  Last update: 2023-07-10 12:13    [W:0.051 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site