Messages in this thread Patch in this message | | | Date | Tue, 11 Jul 2023 11:39:03 +0800 | From | sunran001@208suo ... | Subject | [PATCH] drm/nouveau/flcn/msgq: Move assignment outside if condition |
| |
Fixes the following checkpatch errors:
ERROR: do not use assignment in if condition
Signed-off-by: Ran Sun <sunran001@208suo.com> --- drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c index 16b246fda666..52af200b45bc 100644 --- a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c +++ b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c @@ -203,7 +203,8 @@ nvkm_falcon_msgq_new(struct nvkm_falcon_qmgr *qmgr, const char *name, { struct nvkm_falcon_msgq *msgq = *pmsgq;
- if (!(msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL))) + msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL); + if (!msgq) return -ENOMEM;
msgq->qmgr = qmgr;
| |