lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] drm/nouveau/flcn/msgq: Move assignment outside if condition
Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
index 16b246fda666..52af200b45bc 100644
--- a/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
+++ b/drivers/gpu/drm/nouveau/nvkm/falcon/msgq.c
@@ -203,7 +203,8 @@ nvkm_falcon_msgq_new(struct nvkm_falcon_qmgr *qmgr,
const char *name,
{
struct nvkm_falcon_msgq *msgq = *pmsgq;

- if (!(msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL)))
+ msgq = *pmsgq = kzalloc(sizeof(*msgq), GFP_KERNEL);
+ if (!msgq)
return -ENOMEM;

msgq->qmgr = qmgr;
\
 
 \ /
  Last update: 2023-07-11 05:39    [W:1.250 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site