lkml.org 
[lkml]   [2023]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] block: add check that partition length needs to be aligned with block size
Date
Before calling add partition or resize partition, there is no check
on whether the length is aligned with the logical block size.
If the logical block size of the disk is larger than 512 bytes,
then the partition size maybe not the multiple of the logical block size,
and when the last sector is read, bio_truncate() will adjust the bio size,
resulting in an IO error if the size of the read command is smaller than
the logical block size.If integrity data is supported, this will also
result in a null pointer dereference when calling bio_integrity_free.

Signed-off-by: Min Li <min15.li@samsung.com>
---
block/ioctl.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/block/ioctl.c b/block/ioctl.c
index 9c5f637ff153..aa95b5561169 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -35,6 +35,9 @@ static int blkpg_do_ioctl(struct block_device *bdev,

start = p.start >> SECTOR_SHIFT;
length = p.length >> SECTOR_SHIFT;
+ /*check if length is aligned to blocksize*/
+ if (p.length & (bdev_logical_block_size(bdev) - 1))
+ return -EINVAL;

switch (op) {
case BLKPG_ADD_PARTITION:
--
2.34.1
\
 
 \ /
  Last update: 2023-06-26 11:22    [W:0.032 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site