lkml.org 
[lkml]   [2023]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH] sysfs: Replace %p with %pK in the warning of sysfs_emit*
From
According to Documentation/core-api/printk-formats.rst, kernel pointers
need to be printed with %pK format specifier to respect kptr_restrict in
sysctl.

Also replace the function names in the strings with %s and __func__ as
checkpatch.pl suggested.

Signed-off-by: Kyle Tso <kyletso@google.com>
---
fs/sysfs/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
index a12ac0356c69..56712f0886ef 100644
--- a/fs/sysfs/file.c
+++ b/fs/sysfs/file.c
@@ -732,7 +732,7 @@ int sysfs_emit(char *buf, const char *fmt, ...)
int len;

if (WARN(!buf || offset_in_page(buf),
- "invalid sysfs_emit: buf:%p\n", buf))
+ "invalid %s: buf:%pK\n", __func__, buf))
return 0;

va_start(args, fmt);
@@ -760,7 +760,7 @@ int sysfs_emit_at(char *buf, int at, const char *fmt, ...)
int len;

if (WARN(!buf || offset_in_page(buf) || at < 0 || at >= PAGE_SIZE,
- "invalid sysfs_emit_at: buf:%p at:%d\n", buf, at))
+ "invalid %s: buf:%pK at:%d\n", __func__, buf, at))
return 0;

va_start(args, fmt);
--
2.41.0.162.gfafddb0af9-goog
\
 
 \ /
  Last update: 2023-06-23 16:21    [W:0.039 / U:0.112 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site